Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W-8885816] OFM-NPSP: Automerge major release branches #33

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

spelak-salesforce
Copy link
Contributor

@spelak-salesforce spelak-salesforce commented Feb 12, 2021

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Definition of Done to see any additional details for the items below:

  • Any net new LWC work has JEST test coverage 50% or above
  • Default Sa11y tests pass for all LWC components
  • 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
  • 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
  • Make sure that ACs are updated (if any gaps)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
  • Pull Request contains draft release notes
  • Labels, help text, and customer facing messages are reviewed by Docs
  • QE story level testing completed

@spelak-salesforce spelak-salesforce added no QE needed No changes to metadata directly related to Managed Package ready for dev review Ready for Developer review needs RE review 🔒 This Pull Request still needs a RE review. labels Feb 12, 2021
@spelak-salesforce spelak-salesforce requested a review from a team as a code owner February 12, 2021 18:25
@spelak-salesforce
Copy link
Contributor Author

spelak-salesforce commented Feb 12, 2021

W-8885816

cumulusci.yml Outdated Show resolved Hide resolved
cumulusci.yml Outdated Show resolved Hide resolved
- Removed unintended local file changes
@spelak-salesforce
Copy link
Contributor Author

spelak-salesforce commented Feb 12, 2021

@jstvz , can you give a codeowner review? I think we still need to wait for the NPSP package version on Spring '21 issue to be resolved before all the feature builds run successfully.

@davidmreed
Copy link
Contributor

The feature builds should all succeed. MetaCI is pinned to Spring '21 pods until after R2, which happens late tonight.

Copy link

@seanpat09 seanpat09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@spelak-salesforce spelak-salesforce removed the ready for dev review Ready for Developer review label Feb 16, 2021
@spelak-salesforce
Copy link
Contributor Author

@SalesforceFoundation/release-engineering-reviewers , can we get a code owner review? Thank you!

@spelak-salesforce spelak-salesforce added 🎯 this sprint This Pull Request is related to a Work Item committed in this sprint ready to merge; waiting for merge freeze 🧊🧊🧊 PR is ready to merge, but we are waiting for merge freeze to lift. and removed needs RE review 🔒 This Pull Request still needs a RE review. labels Feb 17, 2021
@spelak-salesforce spelak-salesforce merged commit 19bf673 into master Mar 1, 2021
@spelak-salesforce spelak-salesforce deleted the feature/automerge branch March 1, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no QE needed No changes to metadata directly related to Managed Package ready to merge; waiting for merge freeze 🧊🧊🧊 PR is ready to merge, but we are waiting for merge freeze to lift. 🎯 this sprint This Pull Request is related to a Work Item committed in this sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants