copy currency code to new account #4141
Conversation
|
**lurch: add W-031981 |
|
Tracking W-032112 |
|
@mattparlane, Thank you for your contribution. We have incorporated your suggestion with changes for orgs without multi-currency enabled. Please let us know if there are any questions. |
|
Vunderbar! Any idea what version it will be included in? I'd like to let my people know when it's released. |
|
@sam-knox can you review the changes section to make sure the wording is correct . Thanks |
@mattparlane - It is scheduled to be in the next release |
|
**lurch: attach W-031981 |
|
Tracking W-031981 |
| String defaultCurrency = UserInfo.getDefaultCurrency(); | ||
|
|
||
| Contact newContact = new Contact( | ||
| lastname = 'CurrencyTest', |
There was a problem hiding this comment.
Let's use CamelCase for fields API names, ie LastName and FirstName.
There was a problem hiding this comment.
@RadSFDeveloper Thanks. I've updated the names
…ub.com:SalesforceFoundation/Cumulus into feature/pyan/populate-currency-field-on-create
| @@ -560,6 +560,11 @@ public class ACCT_IndividualAccounts_TDTM extends TDTM_Runnable { | |||
| a.Phone = c.Phone; | |||
| a.Fax = c.Fax; | |||
| a.OwnerId = c.OwnerId; | |||
|
|
|||
| if (UserInfo.isMultiCurrencyOrganization()) { | |||
| a.put('CurrencyIsoCode', String.valueOf(c.get('CurrencyIsoCode'))); | |||
There was a problem hiding this comment.
Let's cast into String, ie a.put('CurrencyIsoCode', (String) c.get('CurrencyIsoCode'));
| * @description Accounts created from the trigger should populate the currency code with the contact | ||
| */ | ||
| @IsTest | ||
| private static void accountCreatedWithCorrectCurrencyCodes() { |
There was a problem hiding this comment.
shouldPopulateNewAccountCurrencyWithContactCurrency()?
|
|
||
| String qryString = 'SELECT Id, Name' + currencyField + ' FROM Account LIMIT 1'; | ||
| Account newAccount = Database.query(qryString); | ||
| System.assertNotEquals(null, newAccount, 'New Account was not created'); |
There was a problem hiding this comment.
Let's specify expected state in the assert statements. For example: New Account should be created or Account Currency should be populated.
| if (isMultiCurrencyEnabled) { | ||
|
|
||
| // Set currency to be something different than the default one if possible | ||
| List<SObject> currencies = Database.query('SELECT IsoCode FROM CurrencyType WHERE IsActive = True'); |
There was a problem hiding this comment.
How about using UTIL_UnitTestData_TEST.nonDefaultCurrencyType for this test? See similar tests in PMT_Payment_TEST.
…ub.com:SalesforceFoundation/Cumulus into feature/pyan/populate-currency-field-on-create
|
@RadSFDeveloper - I've made the requested changes. Thanks |
|
@rponti-sforg This is ready for QA. Thanks |
There was a problem hiding this comment.
QE testing has been completed for this PR. Tests have passed.
For further testing details, see: https://foundation.lightning.force.com/lightning/r/agf__ADM_Work__c/a2x1E000008LlirQAC/view
Merging PR and deleting branch.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata