Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Merge Fixup is Queueable and Calls correct Rollup Process #4084

Merged
merged 146 commits into from
Apr 2, 2019

Conversation

jjbennett
Copy link
Contributor

@jjbennett jjbennett commented Feb 27, 2019

This pull request includes some code cleanup, the move from future to queueable in Contact Merge and ensures the correct rollup process is called on the related Account record.

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

mrbelvedere and others added 26 commits February 11, 2019 17:17
@jjbennett jjbennett changed the title [Do Not Merge] Individual Account TDTM Refactor Contact Merge Fixup is Queueable and Calls correct Rollup Process Mar 25, 2019
@jjbennett
Copy link
Contributor Author

**lurch: attach W-030823

@LurchTheButler
Copy link

Tracking W-030823

@rponti-sforg rponti-sforg added the QE - Test QE is actively testing WI associated with PR label Apr 1, 2019
@rponti-sforg
Copy link
Contributor

@jjbennett Before I merge this, I wanted to confirm with you if this is indeed 'mergeable'... Was there anything else that needed to be 'prepped' for this merge? I ran 'happy-path' regressions for Contact Merge and ran through the Contact Merge Test Scenarios in the WI associated with this PR. Just let me know if you have any questions.

@jjbennett
Copy link
Contributor Author

@rponti-sforg thanks for the double check. Yes, this should be good to merge. You had done the QA on each individual PR but I thought it'd be good to do this last run through on everything together so thank you!

@rponti-sforg
Copy link
Contributor

QE testing is complete for this PR. Tests have passed.

For further testing details, see: https://foundation.lightning.force.com/lightning/r/agf__ADM_Work__c/a2x1E000008Ll0VQAS/view

Merging PR and deleting branch.

@rponti-sforg
Copy link
Contributor

@jjbennett We have a robot test failure on this one:

Build flow qa_org completed with status fail
2019-04-02 09:40:35: MetadataComponentFailure: Update of Layout Campaign-NPSP Campaign Layout: Error: Invalid field:OPPORTUNITY.NAME in related list:RelatedOpportunityList

Just let me know if safe to merge or if you want another build run on it.

@RadSFDeveloper
Copy link
Contributor

@rponti-sforg , @jjbennett : the error on the page layout during the qa build is intermittent and it happened on other PRs' builds in the last week or two. @davidmreed thoughts?

@force2b
Copy link
Contributor

force2b commented Apr 2, 2019

Thanks @RadSFDeveloper.
@rponti-sforg You can merge this.

@davidmreed
Copy link
Contributor

@RadSFDeveloper Our error tracking documents classify the page layout issue (failures with "invalid field in related list") as an intermittent problem solved by a rebuild. We don't have a fix documented.

@rponti-sforg rponti-sforg merged commit ca4a469 into master Apr 2, 2019
@rponti-sforg rponti-sforg deleted the feature/jen-manual-acct-crlp-enabled branch April 2, 2019 17:55
@rponti-sforg rponti-sforg removed the QE - Test QE is actively testing WI associated with PR label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants