-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact Merge Fixup is Queueable and Calls correct Rollup Process #4084
Conversation
…-contact-merge__queueable
**lurch: attach W-030823 |
Tracking W-030823 |
@jjbennett Before I merge this, I wanted to confirm with you if this is indeed 'mergeable'... Was there anything else that needed to be 'prepped' for this merge? I ran 'happy-path' regressions for Contact Merge and ran through the Contact Merge Test Scenarios in the WI associated with this PR. Just let me know if you have any questions. |
@rponti-sforg thanks for the double check. Yes, this should be good to merge. You had done the QA on each individual PR but I thought it'd be good to do this last run through on everything together so thank you! |
QE testing is complete for this PR. Tests have passed. For further testing details, see: https://foundation.lightning.force.com/lightning/r/agf__ADM_Work__c/a2x1E000008Ll0VQAS/view Merging PR and deleting branch. |
@jjbennett We have a robot test failure on this one: Build flow qa_org completed with status fail Just let me know if safe to merge or if you want another build run on it. |
@rponti-sforg , @jjbennett : the error on the page layout during the qa build is intermittent and it happened on other PRs' builds in the last week or two. @davidmreed thoughts? |
Thanks @RadSFDeveloper. |
@RadSFDeveloper Our error tracking documents classify the page layout issue (failures with "invalid field in related list") as an intermittent problem solved by a rebuild. We don't have a fix documented. |
This pull request includes some code cleanup, the move from future to queueable in Contact Merge and ensures the correct rollup process is called on the related Account record.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata