[BUG] Push should use bundle config and not project config.

[nextor2k]

Summary

pwa-kit-dev push should use the bundle config instead of the project config folder.

Steps To Reproduce

1. create a build bundle with a specific config
2. update the project config

Expected result

1. push should deploy the bundle with the config

Actual result

1. push try to push bundle with the project config instead bundle config

System Information (as applicable)

Node version: 14.19.1
pwa-kit version: 2.6
Desktop OS: linux

Additional information

I believe the getConfig on the pwa-kit-dev should be changed to use the one from the bundle.

async ({
    buildDirectory,
    message,
    projectSlug,
    target,
    cloudOrigin,
    credentialsFile
}) => {
    // Set the deployment target env var, this is required to ensure we
    // get the correct configuration object.
    process.env.DEPLOY_TARGET = target

    const credentials = await scriptUtils.readCredentials(credentialsFile)

    // <!> ATENTION BELLOW <!>
    // TODO: use bundle Config Folder instead Project Config Folder.
    const mobify = getConfig() || {} 

    if (!projectSlug) {
        projectSlug = await getProjectName()
    }

    const bundle = await scriptUtils.createBundle({
        message,
        ssr_parameters: mobify.ssrParameters,
        ssr_only: mobify.ssrOnly,
        ssr_shared: mobify.ssrShared,
        buildDirectory,
        projectSlug
    })
    const client = new scriptUtils.CloudAPIClient({
        credentials,
        origin: cloudOrigin
    })

    info(`Beginning upload to ${cloudOrigin}`)
    const data = await client.push(bundle, projectSlug, target)
    const warnings = data.warnings || []
    warnings.forEach(warn)
    success('Bundle Uploaded')
}

[vmarta]

@nextor2k Let's first clarify the differences between a bundle and project configs. Is this what you were thinking of?

• bundle config: inside /build/config folder
• project config: inside /config folder

If that's the case, I think I see what you mean. getConfig in this line should be searching within the /build folder instead, because the intention of the push command is to push the existing bundle in the build folder.

pwa-kit/packages/pwa-kit-dev/bin/pwa-kit-dev.js

Line 293 in 24b8b16

const mobify = getConfig() || {}

Since the script already has access to buildDirectory, perhaps a bug fix would look like:

const mobify = getConfig(buildDirectory) || {}

[nextor2k]

@nextor2k Let's first clarify the differences between a bundle and project configs. Is this what you were thinking of?

• bundle config: inside /build/config folder
• project config: inside /config folder

If that's the case, I think I see what you mean. getConfig in this line should be searching within the /build folder instead, because the intention of the push command is to push the existing bundle in the build folder.

pwa-kit/packages/pwa-kit-dev/bin/pwa-kit-dev.js

Line 293 in 24b8b16

const mobify = getConfig() || {}

Since the script already has access to buildDirectory, perhaps a bug fix would look like:

const mobify = getConfig(buildDirectory) || {}

exactly.

[git2gus]

This issue has been linked to a new work item: W-12546385