Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/downloader.c:136:13: warning: implicit declaration of function 'close'; did you mean 'fclose'? [-Wimplicit-function-declaration] #948

Closed
BaseMax opened this issue Jan 10, 2025 · 5 comments
Assignees
Labels
bug Something isn't working c good first issue Good for newcomers help wanted Extra attention is needed

Comments

@BaseMax
Copy link
Member

BaseMax commented Jan 10, 2025

src/downloader.c: In function 'download':
src/downloader.c:136:13: warning: implicit declaration of function 'close'; did you mean 'fclose'? [-Wimplicit-function-declaration]
  136 |             close(sockfd);
      |             ^~~~~
      |             fclose
@BaseMax BaseMax added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed c labels Jan 10, 2025
@BaseMax
Copy link
Member Author

BaseMax commented Jan 10, 2025

@rico33631
Copy link
Member

@BaseMax I think the warning occurs because the close() function is implicitly declared. replacing close() with the platform-specific CLOSE_SOCKET() macro should resolve the issue.

@BaseMax
Copy link
Member Author

BaseMax commented Jan 13, 2025

@BaseMax I think the warning occurs because the close() function is implicitly declared. replacing close() with the platform-specific CLOSE_SOCKET() macro should resolve the issue.

Yes right, we need to fix it.

@BaseMax
Copy link
Member Author

BaseMax commented Jan 13, 2025

Fixed https://github.com/SalamLang/Salam/actions/runs/12752988238/job/35543629730#logs

Many thanks

@BaseMax BaseMax closed this as completed Jan 13, 2025
@rico33631
Copy link
Member

youre welcome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants