Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hide columns in EDA #1181

Merged
merged 30 commits into from
May 29, 2024
Merged

feat: hide columns in EDA #1181

merged 30 commits into from
May 29, 2024

Conversation

SmiteDeluxe
Copy link
Contributor

Closes #1171

Summary of Changes

  • You can now hide columns by right clicking them
  • Showing either by right click again or by clicking on new column count in sidebar footer (row count there too now)
  • Hidden columns excluded from visualizations that affect whole table (heatmap)
  • Still possible to select in other visualizations but marked red and with "hidden" in case you still want to use that column
  • Hiding/Showing cols marks whole table vis as "outdated"
  • TabContent evaluates which vis types allow non numeric columns and manages buildATab and drop downs based on that

Other fixes/refactors:

  • Context menu on columns
  • Profiling errors present evaluation
  • Color css vars
  • Sidebar width reactivity

SmiteDeluxe added 22 commits May 14, 2024 18:52
@SmiteDeluxe
feat: clean up state and separate it
8a36f5c
@SmiteDeluxe
Merge branch '1169-improve-eda-state' into 1171-hide-column-feature-i…
54ef0a3 
…n-eda
@SmiteDeluxe
feat: hidden columns messaging logic for vis vs. manip
4d8bf10
@SmiteDeluxe
feat: hide columns functionality
79f0aa0
@SmiteDeluxe
feat: making other tabs outdated on relevant changes in history
e98549c
@SmiteDeluxe
fix: improv oudated logic & display
f79923a
@SmiteDeluxe
fix: better hidden col handling for not 'none' col count tabs
2254cf1
@SmiteDeluxe
fix: slightly smaller active tab font
6c8cbea
@SmiteDeluxe
Merge remote-tracking branch 'origin/main' into 1171-hide-column-feat…
6c4de29 
…ure-in-eda
@SmiteDeluxe
fix: only numerical columns in plots other than histogram
0df827f
@SmiteDeluxe
fix: order and fix up col right clicks
4ff5cc0
@SmiteDeluxe
fix: buildATab NonNumerical based changes
573aee7
@SmiteDeluxe
feat: footer basics for col count
2d2810b
@SmiteDeluxe
fix: hidden cols excl. in profiling errors
fb1dcba
@SmiteDeluxe
fix: profiling error store
f66aa3b
@SmiteDeluxe
feat: right click on profiling possible
3b5c772
@SmiteDeluxe
feat: hidden col menu to show
cec02ab
@SmiteDeluxe
refactor: rename color vars
5049fd7
@SmiteDeluxe
fix: z-index of col show menu & fix: reactivity sidebar width changes
03bdd3e
@SmiteDeluxe
fix: only right click interaction allowed on hidden col & styling fixes
c2d96d3
@SmiteDeluxe
fix: hiddenCol reorder drag over & resize min width
01679cc
@SmiteDeluxe
refactor
67d65de
@SmiteDeluxe SmiteDeluxe added enhancement 💡 New feature or request vscode 🔨 Issues regarding tools like the VS Code extension labels May 27, 2024
@SmiteDeluxe SmiteDeluxe requested a review from lars-reimann as a code owner May 27, 2024 14:15
@SmiteDeluxe SmiteDeluxe linked an issue May 27, 2024 that may be closed by this pull request
Hide column feature in EDA #1171
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CSS stylelint 1 0 0 1.91s
✅ JSON prettier 15 0 0 3.25s
✅ REPOSITORY git_diff yes no 0.24s
✅ TSX eslint 14 0 0 8.74s
✅ TYPESCRIPT eslint 6 0 0 7.8s
✅ TYPESCRIPT prettier 6 0 0 1.42s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov Codecov
Copy link

codecov bot commented May 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (846f404) to head (8e2a61b).
Report is 39 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1181   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         110      110           
  Lines       19242    19242           
  Branches     4108     4108           
=======================================
  Hits        19202    19202           
  Misses         40       40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SmiteDeluxe SmiteDeluxe mentioned this pull request May 29, 2024
Merged
lars-reimann
lars-reimann requested changes May 29, 2024
View reviewed changes
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, as usual. Just a few stylistic requests.

packages/safe-ds-eda/src/apis/historyApi.ts Outdated Show resolved Hide resolved
packages/safe-ds-eda/src/apis/historyApi.ts Show resolved Hide resolved
packages/safe-ds-eda/src/components/ColumnCounts.svelte Outdated Show resolved Hide resolved
packages/safe-ds-vscode/src/extension/eda/apis/runnerApi.ts Outdated Show resolved Hide resolved
packages/safe-ds-eda/src/components/tabs/TabContent.svelte Outdated Show resolved Hide resolved
packages/safe-ds-eda/src/components/tabs/TabContent.svelte Outdated Show resolved Hide resolved
packages/safe-ds-eda/src/components/tabs/TabContent.svelte Outdated Show resolved Hide resolved
@lars-reimann lars-reimann merged commit 15ccaac into main May 29, 2024
7 checks passed
@lars-reimann lars-reimann deleted the 1171-hide-column-feature-in-eda branch May 29, 2024 14:13
lars-reimann pushed a commit that referenced this pull request May 29, 2024
@semantic-release-bot
chore(release): 0.17.0 [skip ci]
4c93458 
## [0.17.0](v0.16.1...v0.17.0) (2024-05-29)

### Features

* hide columns in EDA ([#1181](#1181)) ([15ccaac](15ccaac)), closes [#1171](#1171)
* infer column type using runner ([#1182](#1182)) ([846f404](846f404)), closes [#994](#994)
* integrate version 0.26.0 of the `safe-ds` Python library ([#1184](#1184)) ([e79de17](e79de17))
* show symbol types in headings and table of contents ([#1178](#1178)) ([b2f0966](b2f0966)), closes [#1164](#1164)
* sort rows in EDA ([#1183](#1183)) ([ddd5186](ddd5186)), closes [#1151](#1151)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lars-reimann lars-reimann lars-reimann approved these changes

Assignees
No one assigned
Labels
enhancement 💡 New feature or request released Included in a release vscode 🔨 Issues regarding tools like the VS Code extension
Projects
DSL
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide column feature in EDA
3 participants
@SmiteDeluxe @lars-reimann @megalinter-bot