From e6e518efaf5296a211b6c16b2e926872cc2ed446 Mon Sep 17 00:00:00 2001 From: Yann Pringault Date: Thu, 17 Feb 2022 09:16:42 -0800 Subject: [PATCH] Remove prettier from dependencies (#33125) Summary: `prettier` should not be declared in dependencies in the ESLint config because it can trigger issues when a different version is installed on the client app. `prettier` is already declared as `peerDependencies` and in the [README](https://github.com/facebook/react-native/blob/main/packages/eslint-config-react-native-community/README.md), it's explicitly asked to install it: ``` yarn add --dev eslint prettier react-native-community/eslint-config ``` ## Changelog [General] [Fixed] - Remove prettier from dependencies in eslint-config Pull Request resolved: https://github.com/facebook/react-native/pull/33125 Test Plan: - Install the package `react-native-community/eslint-config` and ensure everything works the same as before Reviewed By: yungsters Differential Revision: D34305118 Pulled By: ShikaSD fbshipit-source-id: 65a3a79008cd5e28cc6aa93ef4a5032990b4e9f8 --- packages/eslint-config-react-native-community/package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/eslint-config-react-native-community/package.json b/packages/eslint-config-react-native-community/package.json index 79f74a9ddfccca..9ab1c98af93880 100644 --- a/packages/eslint-config-react-native-community/package.json +++ b/packages/eslint-config-react-native-community/package.json @@ -22,8 +22,7 @@ "eslint-plugin-prettier": "^4.0.0", "eslint-plugin-react": "^7.26.1", "eslint-plugin-react-hooks": "^4.2.0", - "eslint-plugin-react-native": "^3.11.0", - "prettier": "^2.4.1" + "eslint-plugin-react-native": "^3.11.0" }, "peerDependencies": { "eslint": ">=7",