From 67fd5be644a2c6d256c62defd2918d33754a75fb Mon Sep 17 00:00:00 2001 From: Joe Frambach Date: Fri, 1 Apr 2022 06:49:02 -0700 Subject: [PATCH] Fix ESLint and Typescript-ESLint disagreeing about function spacing (#33453) Summary: Fixes https://github.com/facebook/react-native/issues/33452 by replacing deprecated no-spaced-func ESLint rule and adding related TypeScript. Changelog: [General][Fixed] - Update function spacing linting rules See https://github.com/facebook/react-native/issues/33452 - Existing function spacing linting should pass as expected. ## Changelog [CATEGORY] [TYPE] - Message Pull Request resolved: https://github.com/facebook/react-native/pull/33453 Reviewed By: lunaleaps, cortinico Differential Revision: D35011944 Pulled By: GijsWeterings fbshipit-source-id: 441650045d89a01a9114103da0c080643f9cb82c --- packages/eslint-config-react-native-community/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/eslint-config-react-native-community/index.js b/packages/eslint-config-react-native-community/index.js index 34759731a5b2ee..9df5cce4b42b72 100644 --- a/packages/eslint-config-react-native-community/index.js +++ b/packages/eslint-config-react-native-community/index.js @@ -59,6 +59,8 @@ module.exports = { 'no-shadow': 'off', '@typescript-eslint/no-shadow': 1, 'no-undef': 'off', + 'func-call-spacing': 'off', + '@typescript-eslint/func-call-spacing': 1, }, }, { @@ -257,7 +259,7 @@ module.exports = { 'no-empty-character-class': 1, // disallow the use of empty character classes in regular expressions 'no-lonely-if': 0, // disallow if as the only statement in an else block (off by default) 'no-new-object': 1, // disallow use of the Object constructor - 'no-spaced-func': 1, // disallow space between function identifier and application + 'func-call-spacing': 1, // disallow space between function identifier and application 'no-ternary': 0, // disallow the use of ternary operators (off by default) 'no-trailing-spaces': 1, // disallow trailing whitespace at the end of lines 'no-underscore-dangle': 0, // disallow dangling underscores in identifiers