Horizontal Compact Mode issues #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to be found by the bottom utility
ghost
pushed a commit
to medigateio/react-grid-layout
that referenced
this pull request
Feb 3, 2021
react-grid-layout#1390 ---------------------------------------- Fixes react-grid-layout#784 react-grid-layout#1372 react-grid-layout#1376 Horizontal compact mode should not compact vertically by reducing l.y by using the bottom function: It reduces the container and triggers items of the layout with the highest y values to reposition themselves because the repositioning is mixed with the horizontal compaction. So in my opinion, this one line of code needs to be removed (as done in this Pull Request).
|
ping @STRML |
|
Thanks, this looks decent, could you please update the videos though? |
|
Tested this locally, works great. Thanks for the catch! |
|
@STRML thanks for looking into it. I am not sure what you mean by updating the videos. What do you need? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #784 #1372 #1376
Horizontal compact mode should not compact vertically by reducing l.y by using the bottom function: It reduces the container and triggers items of the layout with the highest y values to reposition themselves because the repositioning is mixed with the horizontal compaction. So in my opinion, this one line of code needs to be removed (as done in this Pull Request).
Before:
before.mp4
After:
after.mp4