Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit Commanders Act implementation to support stream type transitions #607

Closed
5 tasks done
defagos opened this issue Oct 20, 2023 · 0 comments · Fixed by #647
Closed
5 tasks done

Revisit Commanders Act implementation to support stream type transitions #607

defagos opened this issue Oct 20, 2023 · 0 comments · Fixed by #647
Assignees
@defagos @waliid
Labels
enhancement New feature or request
Milestone
Analytics

Comments

@defagos
Copy link
Member

defagos commented Oct 20, 2023 •
edited
Loading

As a Pillarbox developer I want the Commanders Act analytics implementation to support stream type transitions from DVR to on-demand.

Acceptance criteria

  • The stream type is provided by the stream, not by the metadata.
  • Analytics, in particular heartbeats, adjust to stream type changes correctly.

Tasks

  • Revisit Commanders Act low-level analytics implementation (comScore-like API).
  • Remove player metadata retrieval closure entirely.
  • Remove stream type from tracker metadata and extract from properties.
  • Adjust comScore implementation similarly, even for small windows.
  • Check that the new implementation does not leak.
@defagos defagos converted this from a draft issue Oct 20, 2023
@defagos defagos added the enhancement New feature or request label Oct 20, 2023
@defagos defagos self-assigned this Oct 20, 2023
@defagos defagos mentioned this issue Oct 20, 2023
Closed
1 task
@defagos defagos added this to the Analytics milestone Oct 23, 2023
@defagos defagos moved this from 🚧 In Progress to 📋 Backlog in Pillarbox Oct 23, 2023
@defagos defagos removed their assignment Oct 27, 2023
@defagos defagos mentioned this issue Nov 20, 2023
Closed
1 task
@defagos defagos moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Nov 21, 2023
@defagos defagos mentioned this issue Nov 23, 2023
Merged
5 tasks
@defagos defagos moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Nov 24, 2023
@defagos defagos linked a pull request Nov 24, 2023 that will close this issue
Improve player item tracker API and stream type transition support #647
Merged
5 tasks
@defagos defagos closed this as completed Nov 24, 2023
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@defagos defagos

@waliid waliid

Labels
enhancement New feature or request
Projects
Pillarbox
Archived in project
Milestone
Analytics
Development

Successfully merging a pull request may close this issue.

Improve player item tracker API and stream type transition support SRGSSR/pillarbox-apple
2 participants
@defagos @waliid