Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move items into consolidated properties #583

Closed
2 tasks done
defagos opened this issue Oct 6, 2023 · 1 comment · Fixed by #602
Closed
2 tasks done

Move items into consolidated properties #583

defagos opened this issue Oct 6, 2023 · 1 comment · Fixed by #602
Assignees
Labels
enhancement New feature or request

Comments

@defagos
Copy link
Member

defagos commented Oct 6, 2023

As a developer integrating Pillabox I want to be able to listen to consistent state information (introduced in #559). This is currently not the case with items stored within the player.

Acceptance criteria

  • Player items have been consolidated in player properties (if meaningful).

Tasks

  • Consolidate properties by adding stored items as well if this makes sense.
  • Even if the above does not make sense, consolidate Control Center publishers so that they all emerge from the same item update stream.
@defagos defagos added this to Pillarbox Oct 6, 2023
@defagos defagos converted this from a draft issue Oct 6, 2023
@defagos defagos added the enhancement New feature or request label Oct 6, 2023
@defagos defagos linked a pull request Oct 13, 2023 that will close this issue
5 tasks
@defagos
Copy link
Member Author

defagos commented Oct 13, 2023

I consolidate item change updates in a way similar to how we consolidate properties. For the rest the implementation is likely good enough.

@defagos defagos moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Oct 13, 2023
@defagos defagos self-assigned this Oct 13, 2023
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant