Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move playback speed into consolidated properties #581

Closed
2 tasks done
defagos opened this issue Oct 6, 2023 · 1 comment · Fixed by #601
Closed
2 tasks done

Move playback speed into consolidated properties #581

defagos opened this issue Oct 6, 2023 · 1 comment · Fixed by #601
Assignees
@defagos @waliid
Labels
enhancement New feature or request

Comments

@defagos
Copy link
Member

defagos commented Oct 6, 2023 •
edited
Loading

As a developer integrating Pillabox I want to be able to implement custom trackers by listening to property changes only. The playback speed is currently not part of properties (introduced in #559), leading to friction when implementing a custom tracker.

Acceptance criteria

  • The playback speed is merged into the player properties.
  • Built-in and custom trackers do not observe playback speed changes with a deferred objectWillChange.

Tasks

  • Consolidate properties by adding playback speed as well.
  • Update tracker implementations.
@defagos defagos added this to Pillarbox Oct 6, 2023
@defagos defagos converted this from a draft issue Oct 6, 2023
@defagos defagos moved this from ✏️ Draft to 📋 Backlog in Pillarbox Oct 6, 2023
@defagos defagos added the enhancement New feature or request label Oct 6, 2023
@defagos defagos moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Oct 12, 2023
@defagos defagos changed the title Move payback speed into consolidated properties Move playback speed into consolidated properties Oct 13, 2023
@defagos
Copy link
Member Author

defagos commented Oct 13, 2023

We could remove the objectWillChange trick in #580. Effective rate observation is not really interesting since we can observe the rate property anyway (and ignore zero values if needed).

@defagos defagos linked a pull request Oct 13, 2023 that will close this issue
Improve playback speed support implementation #601
Merged
5 tasks
@defagos defagos moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Oct 13, 2023
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@defagos defagos

@waliid waliid

Labels
enhancement New feature or request
Projects
Pillarbox
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve playback speed support implementation SRGSSR/pillarbox-apple
2 participants
@defagos @waliid