Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space typos in ERS codes prevents programatic usage #349

Closed
jfy133 opened this issue Jan 7, 2021 · 1 comment · Fixed by #357
Closed

Space typos in ERS codes prevents programatic usage #349

jfy133 opened this issue Jan 7, 2021 · 1 comment · Fixed by #357
Assignees
Labels
bug Something isn't working

Comments

@jfy133
Copy link
Member

jfy133 commented Jan 7, 2021

Describe the bug
Some entries in archive_accession fields have accidently left in spaces which breaks programmatic processing. We should ensure this field does not contain them with a regex in the JSON (or in AncientMetagenomeDirCheck).

Examples are:

SRS3078134, SRS3078129 (in the middle)
SRS3078134,SRS3078129 (at the end)

Additional context
Add any other context about the problem here such as supporting citations or referennces

@jfy133 jfy133 added the bug Something isn't working label Jan 7, 2021
@jfy133 jfy133 changed the title Bug Report Space typos in ERS codes prevents programatic usage Jan 8, 2021
@maxibor maxibor self-assigned this Jan 12, 2021
@maxibor
Copy link
Collaborator

maxibor commented Jan 18, 2021

For reference, this is the solution:

"archive_accession": {
                "$id": "#/items/properties/archive_accession",
                "type": [
                    "string",
                    "null"
                ],
                "pattern": "[^ ]*",
                "title": "Archive accession number",
                "description": "Samples archive accession numbers, multiple records can be separated with commas. No spaces allowed",
                "examples": [
                    "SRS473742,SRS473743,SRS473744,SRS473745"
                ]
            }

Waiting for another issue to be fixed (#356) to propose it as a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants