Replace Czech Republic with Czechia #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the official name of the country "Czech Republic" was changed to Czechia, the website https://unstats.un.org/unsd/methodology/m49/ changed it, too. The commit changes all occurrences of "Czech Republic to Czechia" and updates the JSON file with the allowed values.
|
I used this: https://www.insdc.org/submitting-standards/geo_loc_name-qualifier-vocabulary/ (as that's what ENA uses) as our source of truth. I see the change has been made there too - maybe just update the entire JSON with the updated list to see if tehre are any other new names? |
|
AMDirT, version 1.6.2 SamplesAncient Metagenome Host AssociatedInvalid dataset
Ancient Single Genome Host AssociatedInvalid dataset
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
|
|
Yes, the link that I posted (https://unstats.un.org/unsd/methodology/m49/) is the underlying source for https://www.insdc.org/submitting-standards/geo_loc_name-qualifier-vocabulary/. I pulled the list and added the additional three changes to the JSON file. However, none of them affected our tables. |
jfy133
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the official name of the country "Czech Republic" was changed to Czechia, the website https://unstats.un.org/unsd/methodology/m49/ changed it, too. This PR changes all occurrences of "Czech Republic" to "Czechia" and updates the JSON file with the allowed values.