Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secure way to setup google auth client key #42

Open
SOunit opened this issue Sep 6, 2021 · 0 comments
Open

secure way to setup google auth client key #42

SOunit opened this issue Sep 6, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@SOunit
Copy link
Owner

SOunit commented Sep 6, 2021

path

client/src/components/googleAuth/GoogleAuth.tsx
client/src/util/keys.ts

point to fix

client id is in react.
any user can see it.
is this bad?
or is this ok because there's access limitation in google platform?
(only by "http://localhost:3000" now)

solution

use backend and proxy to hide client key from users

ref

tried ( not recommended )

  • add environment variable docker-compose file
  • add environment variable to react
@SOunit SOunit added the bug Something isn't working label Sep 6, 2021
@SOunit SOunit self-assigned this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant