-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MHKiT Generated Spectra #88
Comments
Unless I misunderstand, MHKit in MATLAB is a wrapper for MHKit Python. I don’t think its worthwhile to make the user install Python. As a third option, we can also code up our own sea states pretty easily.
|
Agreed. I didn't realise it requires a python dist to run, sorry. Closing. |
Reopened with a different perspective. |
I agree with that statement. Please let the MHKiT team know how we can help. And yes, MHKiT has a dependency on Python, but the pro of this approach is that there are no additional MATLAB toolboxes required to run MHKiT-MATLAB. I haven't run WAFO in years, but I thought it had some MATLAB package dependencies. yes/no? |
The focus of the WecOptTool is on control codesign. At this time given the limited project budget, this feature is seen to offer little to no capabilities over using WAFO. We can revisit/ reopen in the future. |
Originally posted by @kmruehl in https://github.com/SNL-WaterPower/WecOptTool/issues/65#issuecomment-605360662
Although MHKiT shouldn't replace WAFO as the primary spectrum format, due to its dependency on Python as discussed below, it would be helpful if we were able to support spectra generated by MHKiT users.
This could be as a conversion to WAFO format in MHKit or here in WecOptTool.
The text was updated successfully, but these errors were encountered: