Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MHKiT Generated Spectra #88

Closed
H0R5E opened this issue Mar 28, 2020 · 5 comments
Closed

Support MHKiT Generated Spectra #88

H0R5E opened this issue Mar 28, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@H0R5E
Copy link
Member

H0R5E commented Mar 28, 2020

  • Why not use MHKiT instead of WAFO? This is also developed through WPTO funding and we can modify it as need be to support this program. It would be nice to see WPTO funded projects leverage other WPTO funded projects.

Originally posted by @kmruehl in https://github.com/SNL-WaterPower/WecOptTool/issues/65#issuecomment-605360662

Although MHKiT shouldn't replace WAFO as the primary spectrum format, due to its dependency on Python as discussed below, it would be helpful if we were able to support spectra generated by MHKiT users.

This could be as a conversion to WAFO format in MHKit or here in WecOptTool.

@H0R5E H0R5E added the enhancement New feature or request label Mar 28, 2020
@H0R5E H0R5E mentioned this issue Mar 28, 2020
7 tasks
@ryancoe
Copy link
Member

ryancoe commented Mar 28, 2020 via email

@H0R5E
Copy link
Member Author

H0R5E commented Mar 28, 2020

Agreed. I didn't realise it requires a python dist to run, sorry. Closing.

@H0R5E H0R5E closed this as completed Mar 28, 2020
@H0R5E H0R5E changed the title Investigate use of MHKiT to replace WAFO Support MHKiT Generated Spectra Mar 28, 2020
@H0R5E
Copy link
Member Author

H0R5E commented Mar 28, 2020

Reopened with a different perspective.

@H0R5E H0R5E reopened this Mar 28, 2020
@ryancoe ryancoe added this to the 0.x milestone Mar 30, 2020
@kmruehl
Copy link

kmruehl commented Mar 30, 2020

it would be helpful if we were able to support spectra generated by MHKiT users.

This could be as a conversion to WAFO format in MHKit or here in WecOptTool.

I agree with that statement. Please let the MHKiT team know how we can help. And yes, MHKiT has a dependency on Python, but the pro of this approach is that there are no additional MATLAB toolboxes required to run MHKiT-MATLAB. I haven't run WAFO in years, but I thought it had some MATLAB package dependencies. yes/no?

@H0R5E H0R5E modified the milestones: 0.x, 1.x Apr 17, 2020
@ssolson ssolson self-assigned this Apr 20, 2020
@H0R5E H0R5E removed this from the 1.0 milestone Jul 9, 2020
@ssolson
Copy link
Collaborator

ssolson commented Oct 16, 2020

The focus of the WecOptTool is on control codesign. At this time given the limited project budget, this feature is seen to offer little to no capabilities over using WAFO. We can revisit/ reopen in the future.

@ssolson ssolson closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants