Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Checking installNemoh #69

Closed
ssolson opened this issue Mar 25, 2020 · 4 comments · Fixed by #102
Closed

Error Checking installNemoh #69

ssolson opened this issue Mar 25, 2020 · 4 comments · Fixed by #102
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ssolson
Copy link
Collaborator

ssolson commented Mar 25, 2020

There does not seem to be a test at the end of installNemoh. We should run an error check at the end of this script. I would think we would basically call the checkNemoh part of the dpendencyCheck? Below is an example where the script did not work but I had to run the dependency Check to determine that.

image

@ssolson ssolson added the enhancement New feature or request label Mar 25, 2020
@ssolson ssolson self-assigned this Mar 25, 2020
@ssolson
Copy link
Collaborator Author

ssolson commented Mar 25, 2020

My issue ended up being that somehow Mesh.exe was deleted.

image

@ssolson
Copy link
Collaborator Author

ssolson commented Mar 25, 2020

So I think that if we were going to add this check we would call isNehmohInPath.m. Then add a verbose option and error catching. Thoughts?

@H0R5E
Copy link
Member

H0R5E commented Mar 25, 2020

I would check the result of isNehmohInPath and then print a success or failure message. Something like:

NEMOH successfully installed

and

NEMOH not found on the specified path

@H0R5E
Copy link
Member

H0R5E commented Mar 25, 2020

From dependencyCheck:

% NEMOH output stored in fixed user-centric location
if ispc
    appDataPath = getenv('APPDATA');
    WOTDataPath = [appDataPath filesep 'WecOptTool'];
else
    appDataPath = getenv('HOME');
    WOTDataPath = [appDataPath filesep '.wecopttool'];
end

nemohExistFlag = WecOptLib.nemoh.isNemohInPath(WOTDataPath);

@H0R5E H0R5E mentioned this issue Mar 28, 2020
7 tasks
@ryancoe ryancoe added this to the v0 release milestone Mar 30, 2020
@ssolson ssolson linked a pull request Mar 31, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants