Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ruff (instead of pylint (and isort)) #192

Merged
merged 22 commits into from
Dec 14, 2023
Merged

Commits on Oct 9, 2023

  1. Update to ruff (instead of pylint (and isort))

    Remove pylint as a dependency.
    Remove all "# pylint: disable=..." statements.
    Remove pylint and isort as pre-commit hooks.
    Add ruff as a pre-commit hook.
    Avoid running pylint in the CI.
    Add a 'ruff' CI job.
    
    Add (back) disable E501 statements.
    E501: Line too long.
    Add it for either lines with string-formatted type (which has to be on
    one line) or an f-string with a single variable (i.e., a single-line
    f-string part with an implemented logic for a variable that results in
    the line being too long).
    CasperWA committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    cd41192 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Remove ruff CI job

    Ruff is already run as part of pre-commit.
    CasperWA committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    7e50658 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Configuration menu
    Copy the full SHA
    97965e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Fix indentation

    CasperWA committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b47d72a View commit details
    Browse the repository at this point in the history
  2. Use the latest ruff version

    CasperWA committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    4727377 View commit details
    Browse the repository at this point in the history
  3. Add explicit rule set to ruff

    Extend arguments to ruff CLI, ensuring no unsafe fixes are made and any
    fixes are shown explicitly in the output.
    CasperWA committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0555740 View commit details
    Browse the repository at this point in the history
  4. Split ruff jobs according to (non-)code base

    Extend rule set for job on code base to include flake8-blind-except and
    pylint.
    Ignore self assignment of variable rule.
    Ignore all too-many-* rules from pylint, because we will extend the
    recommended number of branches, statements, function args, etc. in this
    code base.
    
    Otherwise, run with a rule set that includes pycodestyle, pyflakes,
    pyupgrade, flake8-bugbear, flake8-simplify, isort, and ruff.
    CasperWA committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    1d83102 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    18a8bae View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ee89b67 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Configuration menu
    Copy the full SHA
    08591d7 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    7f639c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Merge remote-tracking branch 'origin/main' into cwa/close-191-use-ruff

    Also:
    - Remove pyupgrade (UP) rule for ruff.
      An actual pyupgrade hook should be used instead.
    - Remove bandit (S) rule for ruff hooks for core code base.
      The bandit hook takes care of these.
    - Update hook versions.
    - Switch hook activation order; run black before ruff.
    - Add python_version-specific pre-commit version in the 'dev' extra.
    - Add a typing.NamedTuple for an ignore entry pair.
      This is used to minimize mypy ignore statements.
    CasperWA committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    265a98a View commit details
    Browse the repository at this point in the history
  2. Add pyupgrade pre-commit hook

    Enforce importing __future__.annotations in all Python files.
    Update code accordingly.
    CasperWA committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    b454e3a View commit details
    Browse the repository at this point in the history
  3. Fix constant definitions

    CasperWA committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    9b4b175 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Configuration menu
    Copy the full SHA
    7377032 View commit details
    Browse the repository at this point in the history
  2. Update ruff rules to match scientific-python

    Or rather, base it on scientific-python and then update it to fit this
    package.
    
    Update the code base accordingly.
    CasperWA committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    b087615 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Configuration menu
    Copy the full SHA
    3242819 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Configuration menu
    Copy the full SHA
    da5cfa6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5c3f49e View commit details
    Browse the repository at this point in the history
  3. Fix wrong merge

    CasperWA committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    182dbb9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c886a27 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    40d3a23 View commit details
    Browse the repository at this point in the history