Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge testing dependencies in pyproject.toml #93

Closed
jesper-friis opened this issue Dec 11, 2022 · 1 comment
Closed

Acknowledge testing dependencies in pyproject.toml #93

jesper-friis opened this issue Dec 11, 2022 · 1 comment
Assignees

Comments

@jesper-friis
Copy link
Contributor

PR EMMC-ASBL/tripper#52 fails due to external CI/CD tests implemented in this repo.

See issue EMMC-ASBL/tripper#48 for a motivation for the failing PR.

The only change in the PR was to move some optional dependencies from dependencies to testing in pyproject.toml.
Since this is a testing framework, it should acknowledge testing dependencies.

@CasperWA
Copy link
Collaborator

It's up to the given repository that uses ci-cd to parse the correct extra installations: https://sintef.github.io/ci-cd/latest/workflows/ci_tests/#run-pylint-safety https://sintef.github.io/ci-cd/latest/workflows/ci_tests/#build-mkdocs-documentation

Here I've linked the documentation for the tests that seems to fail in your link.

Since this is not an issue of this repository, I am closing this issue. One should however probably be opened and fixed in your repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants