Skip to content
This repository has been archived by the owner on May 29, 2022. It is now read-only.

Assert failing in debug build for MSVC 2017 14.1 #53

Open
Drazuam opened this issue Dec 20, 2018 · 0 comments
Open

Assert failing in debug build for MSVC 2017 14.1 #53

Drazuam opened this issue Dec 20, 2018 · 0 comments

Comments

@Drazuam
Copy link

Drazuam commented Dec 20, 2018

There's an issue with FFTextStream.cpp looking at memory before it's char buffer, which is throwing an exception on debug builds in windows. Looks like it probably wouldn't be much of an issue on a "dumber" build or system that's not checking these types of things.

Simple fix though. line 157:

while (*line.rbegin() == '\r')

needs to change to:
while (line[0]!='\0' && *line.rbegin() == '\r')

This will cause the while to exit before it can check the rbegin() function, and it wont access memory wrongly.

Edit: I made this change and it solved the issue for me locally

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant