Skip to content
This repository has been archived by the owner on May 29, 2022. It is now read-only.

License is LGPL, but current cmake config creates a static library on Windows #24

Open
rconde01 opened this issue Dec 27, 2016 · 0 comments

Comments

@rconde01
Copy link

Statically linking violates the LGPL in the case the library is linked with proprietary code and the source of the proprietary code is not delivered:

http://stackoverflow.com/questions/10130143/gpl-lgpl-and-static-linking

For this reason, it probably makes sense to change the default cmake config to generate a shared library on windows. Since this is already the case for non-windows platforms, I would guess the issue is maybe that symbols aren't exported by default with Visual Studio and it was not desired to decorate the classes. In this case, cmake has a solution:

https://cmake.org/cmake/help/v3.4/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html

Another alternative is to make an exception in the license (although I'm unsure if gpstk is using other LGPL code that would prevent this).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant