Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed point intermediary type #1545

Open
2 tasks
heinezen opened this issue Sep 17, 2023 · 3 comments
Open
2 tasks

Fixed point intermediary type #1545

heinezen opened this issue Sep 17, 2023 · 3 comments
Labels
good first issue Suitable for newcomers hacktoberfest For newcomers from Hacktoberfest event improvement Enhancement of an existing component lang: c++ Done in C++ code

Comments

@heinezen
Copy link
Member

Required Skills: C++

Difficulty: Medium

We could use an optional intermediary type for fixed-point types. Intermediary types are used for temporary values in calculations where intermediary steps can cause the original values to overflow. A common scenario where this can happen are multiplication or division. We take inspiration for this from the fpm library.

Intermediary types are only strictly necessary if the base type is small, e.g. int16_t. Therefore, their usage should be optional.

Tasks

  • Add intermediary type as optional template parameter
  • Use intermediary type in fixed-point calculations

Further Reading

@heinezen heinezen added improvement Enhancement of an existing component lang: c++ Done in C++ code good first issue Suitable for newcomers labels Sep 17, 2023
@heinezen
Copy link
Member Author

@ArcXeon Sure, go ahead :)

@ArcXeon ArcXeon removed their assignment Oct 8, 2023
@Pranshu-S
Copy link

Hey, I'd like to give this a shot.
Thanks!

@heinezen
Copy link
Member Author

heinezen commented Mar 6, 2024

@Pranshu-S go for it :)

@heinezen heinezen added the hacktoberfest For newcomers from Hacktoberfest event label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Suitable for newcomers hacktoberfest For newcomers from Hacktoberfest event improvement Enhancement of an existing component lang: c++ Done in C++ code
Projects
Status: other
Development

No branches or pull requests

3 participants