Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the RunConfiguration is correct should be done before the steps #173

Open
mauricioaniche opened this issue May 26, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request Low priority

Comments

@mauricioaniche
Copy link
Contributor

mauricioaniche commented May 26, 2023

We only check if the weights are wrong when GradeCalculator#calculateFinalGrade is called. That only happens at the very end of the process, after compiling, running, and etc. We can move these checks to earlier in the process so that if the teacher made a mistake in the rubric, we get an early error.

One place to do it would be the GetRunConfigurationStep.

@mauricioaniche mauricioaniche added enhancement New feature or request Low priority labels May 26, 2023
@just-rares
Copy link

Hello!

@mauricioaniche
Copy link
Contributor Author

This issue is yours, @just-rares!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Low priority
Projects
None yet
Development

No branches or pull requests

2 participants