Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SCIP 7.0.0 #149

Merged
merged 12 commits into from
Apr 8, 2020
Merged

Support SCIP 7.0.0 #149

merged 12 commits into from
Apr 8, 2020

Conversation

rschwarz
Copy link
Collaborator

@rschwarz rschwarz commented Apr 1, 2020

No description provided.

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #149 into master will increase coverage by 0.89%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage    88.5%   89.39%   +0.89%     
==========================================
  Files          21       21              
  Lines         800      792       -8     
==========================================
  Hits          708      708              
+ Misses         92       84       -8
Impacted Files Coverage Δ
src/init.jl 87.5% <100%> (ø) ⬆️
src/MOI_wrapper.jl 93.42% <0%> (+1.21%) ⬆️
src/managed_scip.jl 95.65% <0%> (+1.36%) ⬆️
src/MOI_wrapper/variable.jl 87.7% <0%> (+2.1%) ⬆️
src/conshdlr.jl 87.5% <0%> (+3.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bdcf43...da7344b. Read the comment docs.

@rschwarz
Copy link
Collaborator Author

rschwarz commented Apr 1, 2020

Still want to update Travis CI to use the newest SCIP, but the downloads are not ready yet?!

@rschwarz rschwarz mentioned this pull request Apr 1, 2020
@fserra
Copy link
Collaborator

fserra commented Apr 1, 2020

i have no idea why it still doesn't find it. Can one do an "ls" on C:\scipoptdir\lib?

@rschwarz
Copy link
Collaborator Author

rschwarz commented Apr 1, 2020

It would be easiest to test this on a local Win machine first, I guess.

But yes, there is Base.Filesystem.pwd() and Base.Filesystem.readdir() in Julia. You can call println( ... ) around these.

@fserra
Copy link
Collaborator

fserra commented Apr 1, 2020

scip now needs tbb. and in windows is not finding the tbb.dll so we need to install it i guess. Apparently it works out of the box in linux

@rschwarz
Copy link
Collaborator Author

rschwarz commented Apr 1, 2020

So, you mean that there is an additional dynamic library file, but it's missing from the installer?

This also implies that the error message from our build.jl is not really accurate, because in reality, the scip.dll file might exist, but dlopen fails because of some unresolved symbol or so?

EDIT: In any case, I'm sure you can figure out for 7.0.1 and PySCIPOpt and then we just replicate what ever needs done here :-)

@fserra
Copy link
Collaborator

fserra commented Apr 2, 2020

yes I guess. So the libscip.dll was ok (I changed it to libscip.lib which is wrong). But I guess it identifies that libscip.dll is not really the dll needed because it doesn't resolve everything. And yes, the error is not really transparent in saying where the file was not found or not useful.

This reverts commit 4f825b2.
@rschwarz
Copy link
Collaborator Author

rschwarz commented Apr 8, 2020

@fserra: Windows now works with the new binaries, but OS X is failing when building from source, see https://travis-ci.org/github/SCIP-Interfaces/SCIP.jl/jobs/672463497#L208

By the way, I've previously tried to use pre-compiled binaries for OS X as well, but never got it to work, see #143.

@fserra
Copy link
Collaborator

fserra commented Apr 8, 2020

yeah, i have no idea. I opened an issue in scip.

@rschwarz
Copy link
Collaborator Author

rschwarz commented Apr 8, 2020

I tried again with preinstalled binaries of OS X, and it seems to be missing some dependencies:
https://travis-ci.org/github/SCIP-Interfaces/SCIP.jl/jobs/672477970#L218

 - the tarball was now updated with a fix
 - reverts commit 53f8c7a.
 - reverts commit 52c191a.
@rschwarz rschwarz merged commit a4867f4 into master Apr 8, 2020
@rschwarz rschwarz deleted the rs/scip7 branch April 8, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants