-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows support #122
Add Windows support #122
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 14.11% 14.11%
=======================================
Files 134 134
Lines 4251 4251
=======================================
Hits 600 600
Misses 3651 3651 Continue to review full report at Codecov.
|
Cool, thanks! It would be great if we could also set up appveyor to run automated tests on Windows. |
Maybe we can add it during that PR right away (never done it either) |
The PR needs to add an appveyor file as in: |
@rschwarz I think there are some custom steps because of the way SCIP is imported, you know them better than me |
Yes, that's what I meant.
Yes, SCIP needs to be downloaded and installed. We also need to set the |
- start with generic Julia file from Example.jl - add some SCIP-specific things from PySCIPOpt
@fserra, @mattmilten I've tried to setup AppVeyor integration for SCIP.jl, by installing it to the SCIP-Interfaces group, but only to "selected projects", namely SCIP.jl. If I have disabled the integration for PySCIPOpt through this action (it does not show up in the settings), please let me know or change it back. |
I guess back when I added appveyor, I only added it for PySCIPOpt. Edit: It seems I set it up using my personal account on appveyor/GitHub. I don't think that there will be a conflict |
That's alright. My concern is that I might disabled it for PySCIPOpt inadvertantly. |
The package currently fails to build on Windows with the message
SCIP is currently not supported on "NT"
. This pull request fixes this by modifyingdeps/build.jl
to search for the correct DLL. I have verified not only the package builds successfully with these changes, but also that all unit tests pass.The function
write_depsfile
needed to be modified because, on Windows, thepath
variable contains backslashes which need to be quoted.