Indicator moi

[matbesancon]

changing indicator to MOI version. Requires Project.toml merged first
Only works for MOI master, and soon 0.9 when released

[tkoolen]

Thank you for working on this stuff. I see that SCIP also supports indicator constraints over arbitrary constraint types (super indicator constraints) and that MOI.IndicatorSet is also designed to potentially support that. Just wondering: is supporting those kinds of constraints also on your radar?

[rschwarz]

I think that supporting cons_superindicator should be possible, but would require either some code duplication or refactoring of the code in the ManagedSCIP part and MOI wrapper: Right now, the existing functions related to constraints all do three things: create constraint (data), add constraint to problem, and register constraint for reference counting. To add a constraint as part of super indicator, we would only need the first part, I guess.

[matbesancon]

I think it's not the same SCIP constraint if you have arbitrary constraints, and MOI is meant for linear constraints I believe, including >=, <=, ==

[codecov]

Codecov Report

Merging #121 into master will decrease coverage by 1.32%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   16.49%   15.16%   -1.33%     
==========================================
  Files         135      135              
  Lines        4310     4259      -51     
==========================================
- Hits          711      646      -65     
- Misses       3599     3613      +14

Impacted Files	Coverage Δ
src/MOI_wrapper/indicator_constraints.jl	94.44% <90%> (+29.73%)	⬆️
src/wrapper/scip_param.jl	14.89% <0%> (-12.77%)	⬇️
src/MOI_wrapper/variable.jl	77.19% <0%> (-8.65%)	⬇️
src/MOI_wrapper/objective.jl	78.94% <0%> (-7.9%)	⬇️
src/MOI_wrapper/linear_constraints.jl	80.48% <0%> (-7.32%)	⬇️
src/wrapper/cons_linear.jl	45.45% <0%> (-4.55%)	⬇️
src/MOI_wrapper.jl	87.5% <0%> (-2.98%)	⬇️
src/wrapper/scip_sol.jl	5.55% <0%> (-1.39%)	⬇️
src/MOI_wrapper/results.jl	100% <0%> (ø)	⬆️
src/managed_scip.jl	99.04% <0%> (+3.39%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed32eef...b8c612c. Read the comment docs.

[codecov]

Codecov Report

Merging #121 into master will increase coverage by 0.13%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   16.49%   16.63%   +0.13%     
==========================================
  Files         135      135              
  Lines        4310     4311       +1     
==========================================
+ Hits          711      717       +6     
+ Misses       3599     3594       -5

Impacted Files	Coverage Δ
src/MOI_wrapper/indicator_constraints.jl	94.44% <90%> (+29.73%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed32eef...b8c612c. Read the comment docs.