Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project.toml, rm REQUIRE #119

Merged
merged 6 commits into from
May 10, 2019
Merged

Add Project.toml, rm REQUIRE #119

merged 6 commits into from
May 10, 2019

Conversation

rschwarz
Copy link
Collaborator

@rschwarz rschwarz commented Apr 9, 2019

No description provided.

@rschwarz
Copy link
Collaborator Author

rschwarz commented Apr 9, 2019

Should merge #118 before, PR created prematurely 😕

@matbesancon matbesancon mentioned this pull request May 7, 2019
@rschwarz
Copy link
Collaborator Author

rschwarz commented May 7, 2019

Maybe this should be rebased on master, because it currently (accidentally) contains the commits from #118 as well. #118 should only be merged after a new MOI release (v0.9?) was tagged, which I think didn't happen yet.

@matbesancon
Copy link
Member

this would be practical indeed

@rschwarz
Copy link
Collaborator Author

rschwarz commented May 9, 2019

@matbesancon your Project.toml from #120 looks different from the one I created. I don't actually remember what process I followed, but I see that I'm missing the test dependencies, for example. Feel free to apply those changes as you see fit.

@rschwarz rschwarz changed the title Add Project.tml, rm REQUIRE Add Project.toml, rm REQUIRE May 9, 2019
@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #119 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   14.11%   14.09%   -0.02%     
==========================================
  Files         134      134              
  Lines        4251     4256       +5     
==========================================
  Hits          600      600              
- Misses       3651     3656       +5
Impacted Files Coverage Δ
src/managed_scip.jl 97.08% <0%> (-1.93%) ⬇️
src/MOI_wrapper.jl 81.63% <0%> (-1.71%) ⬇️
src/MOI_wrapper/quadratic_constraints.jl 65.45% <0%> (-1.22%) ⬇️
src/MOI_wrapper/variable.jl 76.52% <0%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d3527...12f42da. Read the comment docs.

@rschwarz rschwarz requested a review from matbesancon May 9, 2019 14:36
Project.toml Outdated Show resolved Hide resolved
@rschwarz
Copy link
Collaborator Author

rschwarz commented May 9, 2019

Thanks for your comments. I believe the first TOML file was generated from the REQUIRE by a script that was shared on Discourse. But that doesn't mean that the version spec will be any good, if there were no upper bounds in the REQUIRE.

Not sure if this should be merged now, to register a release, or better wait on MOI's update to v0.9.

@matbesancon
Copy link
Member

we can register a last release patch, given the fix for Windows, it would be interesting

@rschwarz rschwarz merged commit 7dc6c4d into master May 10, 2019
@rschwarz rschwarz deleted the rs/project_toml branch May 10, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants