Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-breadcrumbs): remove char separators from accessibility announcement #8099

Merged
merged 6 commits into from
Jan 17, 2024
Merged

fix(ui5-breadcrumbs): remove char separators from accessibility announcement #8099

merged 6 commits into from
Jan 17, 2024

Conversation

kgogov
Copy link
Member

@kgogov kgogov commented Jan 12, 2024

No description provided.

@kgogov kgogov marked this pull request as draft January 12, 2024 15:43
@nnaydenow
Copy link
Contributor

Probably the tests are failing due to font loading. I'm not able to reproduce the problem when I start the automated tests locally, neither manually.

@kgogov kgogov marked this pull request as ready for review January 17, 2024 08:23
@kgogov kgogov merged commit ec1fd10 into SAP:main Jan 17, 2024
8 checks passed
@kgogov kgogov deleted the breadcrumbs-acc-improvement branch January 17, 2024 15:33
ilhan007 pushed a commit that referenced this pull request Jan 19, 2024
…ncement (#8099)

* fix(ui5-breadcrumbs): remove char separators from accessibility announcement

* chore: adjust edge case for failing test
tsanislavgatev pushed a commit that referenced this pull request Feb 20, 2024
…ncement (#8099)

* fix(ui5-breadcrumbs): remove char separators from accessibility announcement

* chore: adjust edge case for failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants