fix(ui5-multi-combobox): select all implementation #8066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyap
requested changes
Jan 10, 2024
There was a problem hiding this comment.
- I want to discuss with the team the following scenario:
- open the N-more popover
- deselec from SelectAll button
-> what is the expected result, to have the filtered items but not selected.. if so, isn't it meaningful when the focus is moved to the input field to have the list with the suggestions?
- On mobile device - open the picker, select some suggestions, press show selected button, then deselect all the suggestins (the list remains filtered and the show selected button pressed), press it again in order to see the whole list but do not select any suggestion, then press it once again -> there is no selected suggestions but the "Select All" is presented and selected with the label 0 of 27 which is strange
|
Scroll the suggestions making the first one not visible, close the picker, open it again. Navigate via arrow down through the suggestions - when the focus is over the first one, the list is not scrolled and the item is not visible when on focus |
niyap
approved these changes
Jan 23, 2024
|
Please, create feature request to ui5-list owners before completing the task. |
|
Feature request to improve implementation: #8165 |
ilhan007
pushed a commit
that referenced
this pull request
Jan 25, 2024
tsanislavgatev
pushed a commit
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #5537