Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Topic RD] All components - display focus outline via keyboard only #5749

Closed
1 of 4 tasks
ilhan007 opened this issue Aug 30, 2022 · 4 comments · Fixed by #6084
Closed
1 of 4 tasks

[Topic RD] All components - display focus outline via keyboard only #5749

ilhan007 opened this issue Aug 30, 2022 · 4 comments · Fixed by #6084

Comments

@ilhan007
Copy link
Member

Feature Request Description

As part of the Fiori Next initiative, along with the Horizon theme family, we would like to change the focus outline behaviour as follows: focus should be present only on pressing keyboard keys. Currently we apply focus upon mouse interaction (click) as well. So, we would have to distinguish between these two cases and apply focus outline only in the first case.

Origin issue: #3986

Proposed Solution

There is a native solution, you can make use of :focus-visible pseudo class to set the focus only via keyboard navigation.

When switching to the CSS solution, the focused state and the event handlers that update it should be removed.

Additional Context

For use-cases when the focus outline should be displayed on another HTML element other than the focused one, the ":focus-visible" won't work as it matches the actual focused element.

Example

:host([focused]) .ui5-button-root:after {

}
will become
.ui5-button-root:focus-visible.ui5-button-root:after {

}

Support

Contact UI5 Web Components Core team for all cases that the CSS solution won't work to discuss how to
handle them.

Priority

  • Low
  • Medium
  • High
  • Very High

A clear and concise description of the impact/urgency of the required feature.

Stakeholder Info (if applicable)

  • Organization: SAP UX
@ilhan007
Copy link
Member Author

Hello @SAP/ui5-webcomponents-topic-rd this is a new Feature Request that needs to be evaluated, and eventually planned.

Thanks,
ilhan

@olannyv
Copy link

olannyv commented Sep 5, 2022

@ilhan007 - would there be a different behavior (or side effects) between WC controls and UI5 wrapper controls?

BLI for team Rodopi created: https://jira.tools.sap/browse/BGSOFUIRODOPI-2860

@ilhan007
Copy link
Member Author

ilhan007 commented Dec 13, 2022

Hello @SAP/ui5-webcomponents-topic-rd @olannyv This is done, but it's not clear in which release as the milestone option is not set

Could you select a milestone

Screenshot 2022-12-13 at 19 14 17

@ilhan007
Copy link
Member Author

@ilhan007 - would there be a different behavior (or side effects) between WC controls and UI5 wrapper controls?

BLI for team Rodopi created: https://jira.tools.sap/browse/BGSOFUIRODOPI-2860

I am not aware of any difference in this aspect, do you have something particular in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants