Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectPage: Content adds too large empty section when headerArea autocollapse (when scrolled) #6648

Closed
1 task done
aleksaToljic opened this issue Nov 22, 2024 · 3 comments · Fixed by #6663
Closed
1 task done
Labels

Comments

@aleksaToljic
Copy link

Describe the bug

When the user starts scrolling, headerArea collapses, and a large section is added above the content

Isolated Example

https://stackblitz.com/edit/github-sr4l8x?file=src%2FApp.tsx

Reproduction steps

  1. Start scrolling slowly

Expected Behaviour

Content to not jumb down

Screenshots or Videos

image

UI5 Web Components for React Version

2.4.0

UI5 Web Components Version

2.4.0

Browser

Chrome

Operating System

macOs Sequoia 15.1

Additional Context

No response

Relevant log output

No response

Organization

TronIT

Declaration

  • I’m not disclosing any internal or sensitive information.
@aleksaToljic
Copy link
Author

I have a fix for this, it's pretty straightforward.
The problem is that we add position: absolute to headerArea, when it's collapsed, and it looses it's width, so it looks like this (when I remove visibility: hidden)
Screenshot 2024-11-22 at 14 54 34

Solution for this would be to add left: 0, right: 0 or width:
Screenshot 2024-11-22 at 14 56 03

I can create PR if needed.

@Lukas742
Copy link
Contributor

Hi @aleksaToljic

The linked PR will resolve this issue, so there’s no need to create a PR on your end. Nevertheless, thank you for raising this issue and offering a solution! :)

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.5.0 🎉

The release is available on v2.5.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants