-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AnalyticalTable): offer limited support for infiniteScroll
combined with a grouped table
#6431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined with a grouped table
Size Change: +202 B (+0.05%) Total Size: 402 kB
ℹ️ View Unchanged
|
Pull Request Test Coverage Report for Build 11128913384Details
💛 - Coveralls |
MarcusNotheis
approved these changes
Oct 2, 2024
Lukas742
added a commit
that referenced
this pull request
Oct 2, 2024
…ined with a grouped table (#6431) Using `infiniteScroll` with a grouped table can result in an odd user experience. For example, when rows are lazy-loaded via scrolling, new rows might only be added to existing groups. This won't change the scroll container's height, potentially forcing the user to scroll down again to load more rows. Therefore (and as we don't have a concept for this behavior) __it's not recommended using a grouped table in combination with `infiniteScroll`__!
1 task
🎉 This PR is included in version v2.2.0 🎉 The release is available on v2.2.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
infiniteScroll
with a grouped table can result in an odd user experience. For example, when rows are lazy-loaded via scrolling, new rows might only be added to existing groups. This won't change the scroll container's height, potentially forcing the user to scroll down again to load more rows.Therefore (and as we don't have a concept for this behavior) it's not recommended using a grouped table in combination with
infiniteScroll
!