refactor(FilterBar): remove reference copying of filter/input elements #6214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10486318980Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Size Change: -978 B (-0.24%) Total Size: 408 kB
ℹ️ View Unchanged
|
MarcusNotheis
requested changes
Aug 20, 2024
MarcusNotheis
approved these changes
Aug 20, 2024
|
🎉 This issue has been resolved in version v2.0.0-rc.3 🎉 The release is available on v2.0.0-rc.3 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
FilterBarcomponent was completely overhauled and references of input elements aren’t copied to the filters dialog anymore, also internal logic for reordering and selection has been removed, meaning it’s necessary to control their values manually (e.g. via React state).BREAKING CHANGE:
onToggleFilters: Thedetailproperty of the event now only includesvisibleandnativeDetailproperties.filtersandsearchhave been removed.BREAKING CHANGE:
onFiltersDialogSave: Thedetailproperty of the event now only includesselectedFilterKeys,reorderedFilterKeysandnativeDetailproperties.elements,toggledElements,filters,search,orderIdshave been removed.BREAKING CHANGE:
onFiltersDialogCancel: The event is now a callback instead of aUi5CustomEvent. It implements theescPressedparameter.BREAKING CHANGE:
onFiltersDialogClose: The event is now a callback instead of aUi5CustomEvent. It implements thecloseTriggerparameter.BREAKING CHANGE:
onFiltersDialogSelectionChange: The event is now a callback instead of aUi5CustomEvent. It implements a payload object as parameter.BREAKING CHANGE:
onFiltersDialogSearch: The event is now a standardInputonInputevent. Thedetailpropertiesvalueandelementhave been removed.BREAKING CHANGE:
onClear: The event is now a standardToolbarButtononClickevent. Thedetailpropertiesfiltersandsearchhave been removed.BREAKING CHANGE:
onGo: The event is now a standardToolbarButtononClickevent. Thedetailpropertieselements,filters,search,nativeDetailhave been removed.BREAKING CHANGE:
onRestore: The event is now a callback instead of aCustomEvent. It implements a payload object as parameter.BREAKING CHANGE:
onFiltersDialogOpen (TypeScript): The target of the event is now aToolbarButton.BREAKING CHANGE:
portalContainerhas been removed as it's no longer needed due to the Popover API used in thePopoverui5 web component.BREAKING CHANGE:
FilterGroupItem:orderIdhas been removed. Please usefilterKeyinstead.Fixes #5652