[FIX] Do not prefix excludes when creating a reader #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
requested changes
May 15, 2023
The tests are in the |
|
Oh yeah, my bad. The fact that no tests are failing right now should be definitely a signal that this code is not tested well enough and tests should be added. |
…ion projects Restore the v2 behavior for compatibility reasons. Also see https://github.com/SAP/ui5-fs/blob/1edcd3c68bcec2a1f51831f80a3010bf701c5c4d/lib/resourceFactory.js#L181
…pplication projects correctly
matz3
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: SAP/ui5-tooling#826
Test cases: SAP/ui5-project#609