[FIX] TypeScript type definition support #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy-loading breaks the automatic type definition detection from TypeScript. Therefore we need to manually declare the exported types.
tobiasso85
suggested changes
Jun 26, 2020
jsdoc.json
Outdated
| @@ -7,7 +7,9 @@ | |||
| "includePattern": ".+\\.js$", | |||
| "excludePattern": "(node_modules(\\\\|/))" | |||
| }, | |||
| "plugins": [], | |||
| "plugins": [ | |||
There was a problem hiding this comment.
mixed whitespaces and tabs
There was a problem hiding this comment.
I wonder why we have spaces here but our editorconfig enforces tabs. I'll convert to tabs.
| @@ -56,5 +58,5 @@ | |||
| "id": "github_link" | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
mixed whitespaces and tabs
matz3
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Jun 26, 2020
matz3
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy-loading breaks the automatic type definition detection from
TypeScript. Therefore we need to manually declare the exported types.
Adds a small jsdoc-plugin to remove the import() comments as JSDoc is unable to parse them