[FIX] JSModuleAnalyzer: Fix detection of bundle name #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
force-pushed
the
fix-JSModuleAnalyzer
branch
from
2a9a916 to
57bcf31
Compare
matz3
changed the title
|
Code is ready for review. I will finish and enhance the tests soon. |
Done |
|
LGTM |
codeworrior
reviewed
Apr 25, 2022
| const info = analyzeString(content, "modules/module-with-jquery-sap-declare.js"); | ||
| t.is(info.name, "modules/module-with-jquery-sap-declare.js"); | ||
| t.is(info.rawModule, false); | ||
| t.is(info.format, "ui5-declare", "Format should be declare once a jQuery.sap.declare statement is found"); |
There was a problem hiding this comment.
From the content I would say that the format should be ui5-define, not ui5-declare.
I understand that this was not changed by this PR (and rather is a sleeping bug in the analyzer). But seeing now a test that declares this the "expected" behavior, feels wrong.
Can we at least comment that this needs to be fixed? Or is there a 'todo' variant for 'test' (similar to QUnit.todo)?
codeworrior
approved these changes
Apr 25, 2022
This was referenced May 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.