[FIX] manifestBundler: Add support for i18n object configuration #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test for manifestBundler refs: #457
was adding the first resource twice, therefore added "else" getDescriptorI18nInfo now handles i18n section of sap.app for strings and objects
|
As discussed: we are awaiting feedback on whether a terminologies bundleUrl should also be handled and included in the manifest bundle |
RandomByte
approved these changes
May 19, 2020
There was a problem hiding this comment.
Awesome. Nice to have some dedicated tests for the manifestBundler processor. Now we could also enhance the integration tests of the generateManifestBundler tasks: https://github.com/SAP/ui5-builder/blob/master/test/lib/tasks/bundlers/generateManifestBundle.integration.js
But I would rather merge this now. We anyways need to come back to this topic once we know whether terminologies *.properties files should be bundled as well.
RandomByte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manifestBundler task can handle i18n objects configured in the manifest.json "sap.app" "i18n" section.
It is able to support strings:
{ "sap.app": { "i18n": "i18n/i18n.properties" } }as well as objects.
{ "sap.app": { "i18n": { "bundleUrl": "i18n/i18n.properties", "supportedLocales": ["en", "de"], "fallbackLocale": "en" } } }fixes #457