From 9cd131397c4ec44821980cba40da9fbc963f44fe Mon Sep 17 00:00:00 2001
From: Tobias Sorn <tobias.sorn@sap.com>
Date: Thu, 25 Feb 2021 10:35:30 +0100
Subject: [PATCH] Added TODO for descriptorVersion parameter

The descriptorVersion parameter is not public API, but it makes sense
to make the parameter of type string and create a SemVer object inside.
---
 lib/processors/manifestCreator.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/processors/manifestCreator.js b/lib/processors/manifestCreator.js
index c92621c40..46e0981da 100644
--- a/lib/processors/manifestCreator.js
+++ b/lib/processors/manifestCreator.js
@@ -652,7 +652,7 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in
 module.exports = function({libraryResource, resources, options}) {
 	// merge options with defaults
 	options = Object.assign({
-		descriptorVersion: APP_DESCRIPTOR_V22,
+		descriptorVersion: APP_DESCRIPTOR_V22, // TODO change this to type string instead of a semver object
 		include3rdParty: true,
 		prettyPrint: true
 	}, options);