From 42ce003558ff447c32cfc5502f661fbe771a6235 Mon Sep 17 00:00:00 2001 From: Tobias Sorn Date: Tue, 26 Jan 2021 18:31:40 +0100 Subject: [PATCH] Change logging for missing libraryManifest to verbose With regards to backward compatibility the libraryManifest can be missing. When --all is omitted the libraryManifest can also be missing. --- lib/processors/versionInfoGenerator.js | 2 +- test/lib/processors/versionInfoGenerator.js | 4 ++-- test/lib/tasks/generateVersionInfo.js | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/processors/versionInfoGenerator.js b/lib/processors/versionInfoGenerator.js index 4d66d14a1..25f176ce1 100644 --- a/lib/processors/versionInfoGenerator.js +++ b/lib/processors/versionInfoGenerator.js @@ -288,7 +288,7 @@ async function processManifestAndGetArtifactInfo(libraryManifest, name) { */ const processLibraryInfo = async (libraryInfo) => { if (!libraryInfo.libraryManifest) { - log.warn( + log.verbose( `Cannot add meta information for library '${libraryInfo.name}'. The manifest.json file cannot be found`); return; } diff --git a/test/lib/processors/versionInfoGenerator.js b/test/lib/processors/versionInfoGenerator.js index 67ba49efc..6f09b14f5 100644 --- a/test/lib/processors/versionInfoGenerator.js +++ b/test/lib/processors/versionInfoGenerator.js @@ -85,8 +85,8 @@ test.serial("versionInfoGenerator simple library infos", async (t) => { ] }; assertVersionInfoContent(t, oExpected, result); - t.is(t.context.warnLogStub.callCount, 1); - t.is(t.context.warnLogStub.getCall(0).args[0], + t.is(t.context.verboseLogStub.callCount, 1); + t.is(t.context.verboseLogStub.getCall(0).args[0], "Cannot add meta information for library 'my.lib'. The manifest.json file cannot be found"); }); diff --git a/test/lib/tasks/generateVersionInfo.js b/test/lib/tasks/generateVersionInfo.js index a524809c3..4d8984363 100644 --- a/test/lib/tasks/generateVersionInfo.js +++ b/test/lib/tasks/generateVersionInfo.js @@ -146,8 +146,8 @@ test.serial("integration: Library without i18n bundle file", async (t) => { "version": "1.33.7", }, oOptions); - t.is(t.context.warnLogStub.callCount, 1); - t.is(t.context.warnLogStub.getCall(0).args[0], + t.is(t.context.verboseLogStub.callCount, 1); + t.is(t.context.verboseLogStub.getCall(0).args[0], "Cannot add meta information for library 'test.lib3'. The manifest.json file cannot be found"); });