Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in diffRules function ( no check that oBaseRules is fully processed ) #109

Closed
ThePlenkov opened this issue Jan 2, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@ThePlenkov
Copy link
Contributor

Hi guys,

I managed to figure out how scope concept works and finally ran this module to compare my normal theme file with a contrast one.

However currently i have an unhandled exception. I cannot read fully the code yet to find the exact reason but what happens now:

oCompareNode is undefined in this line
image

where it was found like this:
image

while the length of the array is like this:
image

in my case oBaseRulesarray is smaller than oCompareRules.

It looks like we miss some check that oCompareNode reached the end.

Thank you!

@ThePlenkov ThePlenkov changed the title Error in diffRules function Error in diffRules function ( no check that oBaseRules is fully processed ) Jan 2, 2020
@matz3 matz3 closed this as completed in 9628a6c Jan 7, 2020
@matz3 matz3 added the bug Something isn't working label Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants