From 351ab09b7d2b338d34125bfaf684348303cb6909 Mon Sep 17 00:00:00 2001 From: Miguel Ojeda Date: Sat, 5 Sep 2020 03:13:37 +0200 Subject: [PATCH] Alex's review Signed-off-by: Miguel Ojeda --- Documentation/rust/quick-start.rst | 2 +- rust/kernel/src/filesystem.rs | 2 ++ rust/kernel/src/lib.rs | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/rust/quick-start.rst b/Documentation/rust/quick-start.rst index b88da6a9f9b4be..925848b82c2fa3 100644 --- a/Documentation/rust/quick-start.rst +++ b/Documentation/rust/quick-start.rst @@ -8,7 +8,7 @@ This document describes how to get started with Rust kernel development. Requirements ------------ -A nightly Rust toolchain (at least ``rustc``, ``cargo`` and ``rustfmt``) is required. In the future, this restriction will be lifted. If you are using ``rustup``, run:: +A recent nightly Rust toolchain (at least ``rustc``, ``cargo`` and ``rustfmt``) is required, e.g. `nightly-2020-08-27`. In the future, this restriction will be lifted. If you are using ``rustup``, run:: rustup toolchain install nightly diff --git a/rust/kernel/src/filesystem.rs b/rust/kernel/src/filesystem.rs index 11b415008f680e..a5b7774292f1b2 100644 --- a/rust/kernel/src/filesystem.rs +++ b/rust/kernel/src/filesystem.rs @@ -1,5 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 +// TODO: `filesystem` is really incomplete -- deletion to be considered + use alloc::boxed::Box; use core::default::Default; use core::marker; diff --git a/rust/kernel/src/lib.rs b/rust/kernel/src/lib.rs index bdb070cca95339..1469c77247bceb 100644 --- a/rust/kernel/src/lib.rs +++ b/rust/kernel/src/lib.rs @@ -51,6 +51,8 @@ macro_rules! kernel_module { ($module:ty, $($name:ident : $value:expr),*) => { static mut __MOD: Option<$module> = None; + // Built-in modules are initialized through an initcall pointer + // // TODO: find a proper way to emulate the C macro, including // dealing with `HAVE_ARCH_PREL32_RELOCATIONS` #[cfg(not(module))]