Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS probe #409

Closed
VoxValue opened this issue Mar 20, 2017 · 5 comments
Closed

HTTPS probe #409

VoxValue opened this issue Mar 20, 2017 · 5 comments
Assignees
Milestone

Comments

@VoxValue
Copy link

Hi
There is an HTTP probe, what runs correctly and only for HTTP 'action'.
But, how to monitor HTTPS server (not the express part), on the same basics as HTTP probe ? I didn't anything about that in the documentation, the past issues or in the code.

@sjanuary
Copy link
Contributor

It would be good to do this at some point. As suggested, it will require a new probe to be implemented. Tagged as enhancement.

@anthonywebb
Copy link

I am in need of tracking https-outbound calls that our server is making using the 'request' npm lib. Currently it appears that the 'http-outbound' probe is catching the http stuff. But not the https stuff. Is this a pretty straight forward addition? Just wondering why it was excluded to begin with, it seems like http probes would catch both?

@sjanuary sjanuary added this to the 3.1 milestone Apr 24, 2017
@sjanuary
Copy link
Contributor

It wasn't explicitly excluded, but appmetrics probes match the module name exactly and https is implemented as a separate module in Node, so the http probe only catches calls made via the http module. It will be fairly simple to implement the https probe, it just hasn't been done yet.

@anthonywebb
Copy link

Anyone else need this as much as me? Most apps these days make http requests to https addresses. Would be a nice addition.

@tobespc
Copy link
Member

tobespc commented Jun 14, 2017

@anthonywebb Yep, this is something we intend to do. Its on our radar and we hope to get to this very soon. We also welcome contributors to this project :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants