Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add cancel txn to offer #19

Open
denverbaumgartner opened this issue Sep 1, 2023 · 0 comments
Open

improvement: add cancel txn to offer #19

denverbaumgartner opened this issue Sep 1, 2023 · 0 comments

Comments

@denverbaumgartner
Copy link
Contributor

currently, on both RubiconV2 and RubiconV2_Optimism we are not tracking the transaction that caused the offer to be cancelled. for now, it probably makes the most since just to record the transaction regardless of whether it was a take, cancel, or min order sell cancel on the offer. this removes some level of insight into the cause of the cancel, but solves our immediate needs today. this will be an update to the Offer entity, and will occur any place we are updating the removed_timestamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant