Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type to all nodes #88

Open
RubenVerborgh opened this issue Jul 30, 2019 · 0 comments
Open

Add type to all nodes #88

RubenVerborgh opened this issue Jul 30, 2019 · 0 comments
Labels
enhancement

Comments

@RubenVerborgh
Copy link
Owner

Suggestion by @AlexeyMz at #80 (comment):

May I also suggest to add type constants to other node types as well?

Here are the current typings: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/d2d3a685fe949a4e938fe2913597e49d1e703ef5/types/sparqljs/index.d.ts

It would be great to make these changes:

  1. add type equal to grouping for Grouping, ordering for Ordering, variable for VariableExpression;
  2. change updateType property to type in InsertDeleteOperation (currently half operations use updateType and the other one just type).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RubenVerborgh