-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chainId can be String #15
Comments
Thanks for the PR. |
I will update the chainId type to a |
Since the package is pre 1.0 its probably a good time to make a breaking change, although it's a pretty minor breaking change as its relaxing a type restriction. Waiting for 1.0 is probably going to mean this package doesn't work for many people. |
I've did some more testing and it will be a more breaking change then expected. It might also break current existing storage solutions (e.g. |
any update on this ? we got the problem with Elrond wallet maiar |
Currently chainId is an int, and fails if the chainId is returned as String. It is possible for the chainId to be a String so the param should be a String rather than int.
The text was updated successfully, but these errors were encountered: