Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts with Pocket extension by blocking the Pocket tagging pop up on all pages #42

Open
arcmodo opened this issue Jan 6, 2024 · 0 comments
Assignees

Comments

@arcmodo
Copy link

arcmodo commented Jan 6, 2024

Describe the bug
The Pocket extension is used to save pages to the Pocket service. When PopUpOFF is enabled, the Pocket extension will save the page to Pocket properly, but it does not display the pop up from the Pocket extension where I can add a specific tag to the saved item. This means it goes into my Pocket uncategorized. This is a tricky issue as I don't want to turn off PopUpOFF on the given page, because I would have to do this for every page I want to save to Pocket. Ideally, PopUpOFF would not block a pop up triggered by the Pocket extension.

To Reproduce
Steps to reproduce the behavior:

  1. Install and enable both PopUpOFF and Pocket extension
  2. Visit any page on the web
  3. Ensure PopUpOff is on for the page, I use Moderate
  4. Click on the Pocket extension to save the page
  5. Note the saved page but missing pop up for tagging
  6. Now set PopUpOFF to "Turn Off" and click Pocket extension again
  7. Note the saved page and now the tagging pop up appears

Expected behavior
When clicking the Pocket extension to save the page, the Pocket extension tagging pop up should appear regardless of PopUpOFF setting as this is an extension pop up and not tied to the page itself that I'm on.

Screenshots
pocket-popup-tagging

PC (please complete the following information):

  • OS: W11
  • Browser Edge
  • Version 120

Additional context
Note that the tagging pop up is specific to the Pocket extension and not to the page I'm on. I did have some weirdness when reproducing if PopUpOFF was already set to "Turn Off" for a page. I had to set up back to Moderate then again to Turn Off to get the Pocket pop up to appear. Also, it sometimes appeared when changing PopUpOFF for the page from Moderate to Turn Off and sometimes I had to click the Pocket extension again or after a page refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants