Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take a closer look at Encoding #28

Closed
RolandPheasant opened this issue Nov 22, 2015 · 1 comment
Closed

Take a closer look at Encoding #28

RolandPheasant opened this issue Nov 22, 2015 · 1 comment
Labels

Comments

@RolandPheasant
Copy link
Owner

Currently using Encoding.Default and specifying the detectEncodingFromByteOrderMarks=true in the constructor of the stream reader when indexing a log file. The indexer determines the start position and length of each line including the delimiter. It also determines what the line delimiter is (different for Windows, Mac, Unix).

When the content of the line is read because it comes it view, the Encoding used by the reader is not necessarily the same as used by the stream reader as the code bypasses use stream reader all together. Also in the code it assumes a 2 character windows delimiter.

This need sorting out sooner rather than later!

For reference see:
LineIndexer.cs
FileInfoEx (see last overoad of ReadLines(...) method)

@RolandPheasant
Copy link
Owner Author

Turns out this is an issue which effects the alpha release 0.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant