Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max Room Members limit does not get overridden by user notifications="all messages" #9357

Closed
soundstorm opened this issue Jan 8, 2018 · 13 comments · Fixed by #10686
Closed

Comments

@soundstorm
Copy link
Contributor

soundstorm commented Jan 8, 2018

On our default #general and #offtopic channels, messages just triggering notifications if mentioned, although mobile/desktop notifications are set to trigger on all messages. Still present in 0.60.x

Guess:
Maybe this is a bug caused by Slack import, I'll check my files (but they are older than one year, so have to search for them)
Settings for notifications are not included in Slack export files, so they can't influence this behaviour. I'll have a look into the mongo, but my guess is, that this will reveal nothing helpful.

@soundstorm
Copy link
Contributor Author

soundstorm commented Jan 19, 2018

@sampaiodiego the rid is GENERAL and OFFTOPIC instead of a cryptic string.

@Maqsyo
Copy link

Maqsyo commented Feb 8, 2018

same problem here.
No Mobile/Desktop-Notifications for "all messages". only for mentions

@srgcdev
Copy link

srgcdev commented Mar 24, 2018

Same problem here. I don't receive notifications in channels despite notifications are configured for all messages.

@Hudell
Copy link
Contributor

Hudell commented Mar 27, 2018

I've been trying to replicate the issue here, but the notifications showed up properly every time (except when my status is busy, but that is by design).

@srgcdev
Copy link

srgcdev commented Mar 27, 2018

@Hudell The problem I commented occurs on windows in the channels chats.
I receive the notification (and I can see it during 2 seconds because I configure it this way) but if I miss the notification I can't notice if there are pending message on channels to read because the unread count in the system try icon is not updated and the window in the task bar doesn't blink despite I configure the channel to do that.

@soundstorm
Copy link
Contributor Author

@Hudell as mentioned, the rids on those channels differ from the normal auto-generated string as they are plain text. Don't know if this applies to your installation as well.

@Hudell
Copy link
Contributor

Hudell commented Apr 2, 2018

@soundstorm Yes, the general channel always has that fixed id. I've tried running more tests here and was still unable to replicate the issue.

Have you checked the channel's notification preferences? It overrides the users' global notification preferences, so even if the user is set to display notifications on every message, it will only show notifications on mentions for the channels that are configured like that.

@srgcdev I think your problem may be unrelated to the one described in this issue, as you mentioned that the notification pops up properly.

@soundstorm
Copy link
Contributor Author

soundstorm commented Apr 2, 2018

@Hudell okay, then lets see.
I've set

  • #general to use my global preferences
  • #offtopic to notify on every message

So settings for these channels should work to send out notifications regardless of trigger words (but don't).

@soundstorm
Copy link
Contributor Author

@Hudell can reproduce with any account on our instance.

@soundstorm
Copy link
Contributor Author

> db.rocketchat_room.find({"name":"general"})
{ "_id" : "GENERAL", "ts" : ISODate("2016-12-21T01:26:38.049Z"), "t" : "c", "name" : "general", "usernames" : [ ... ], "msgs" : 1744, "default" : true, "_updatedAt" : ISODate("2018-04-03T19:24:00.097Z"), "lm" : ISODate("2018-04-03T02:15:42.798Z"), "importIds" : [ "C050MEJ2J" ], "topic" : "Wichtige Ankündigungen, Diskussionen und Fragen" }
> db.rocketchat_room.find({"name":"offtopic"})
{ "_id" : "kgYFD5tdpepALBdby", "name" : "offtopic", "t" : "c", "usernames" : [ ... ], "msgs" : 1592, "u" : { "_id" : "FSDQcz2Sd2uYPMbCv", "username" : "joachimh" }, "ts" : ISODate("2016-12-22T10:49:18.624Z"), "ro" : false, "sysMes" : true, "_updatedAt" : ISODate("2018-04-03T19:25:46.533Z"), "importIds" : [ "C050MEJ2L" ], "lm" : ISODate("2018-04-03T19:25:46.504Z"), "default" : true, "topic" : "Eventuell abseits von Arduino - für reinen Quatsch #freitagsgespraech" }
> db.users.find({"username":"sndstrm"})
{ "_id" : "AuFSZhiWTKBnduXPb", "createdAt" : ISODate("2016-12-21T01:36:06.157Z"), "services" : { ... }, "emails" : [ { ...} ], "type" : "user", "status" : "offline", "active" : true, "roles" : [ "admin", "bot", "livechat-manager", "livechat-agent", "user" ], "_updatedAt" : ISODate("2018-04-03T19:22:50.681Z"), "name" : "Luca 卖家", "lastLogin" : ISODate("2018-04-03T19:22:50.681Z"), "statusConnection" : "online", "utcOffset" : 1, "username" : "sndstrm", "statusDefault" : "offline", "language" : "de", "settings" : { "preferences" : { "newRoomNotification" : "none", "newMessageNotification" : "none", "useEmojis" : true, "convertAsciiEmoji" : true, "saveMobileBandwidth" : true, "collapseMediaByDefault" : false, "autoImageLoad" : true, "emailNotificationMode" : "disabled", "roomsListExhibitionMode" : "category", "unreadAlert" : true, "desktopNotifications" : "all", "mobileNotifications" : "all", "enableAutoAway" : false, "highlights" : [ "Luca" ], "desktopNotificationDuration" : 0, "viewMode" : 0, "hideUsernames" : false, "hideRoles" : false, "hideAvatars" : false, "hideFlexTab" : true, "sendOnEnter" : "desktop", "roomCounterSidebar" : false, "sidebarSortby" : "alphabetical", "sidebarShowUnread" : true }, "profile" : {  } }, "avatarOrigin" : "facebook", "importIds" : [ "U0519TXJF" ], "statusLivechat" : "not-available", "operator" : true, "livechatCount" : 1 }

Seems all okay so far.

> db.rocketchat_subscription.find({"name":"general"})
{ "_id" : "wR6xJkLdpfg6js56R", "open" : true, "alert" : false, "unread" : 0, "ts" : ISODate("2017-01-28T10:59:16.626Z"), "rid" : "GENERAL", "name" : "general", "t" : "c", "u" : { "_id" : "AuFSZhiWTKBnduXPb", "username" : "sndstrm" }, "_updatedAt" : ISODate("2018-04-03T17:20:25.165Z"), "ls" : ISODate("2018-04-03T17:20:25.165Z"), "desktopNotifications" : "all", "desktopNotificationDuration" : 0, "userMentions" : 0, "groupMentions" : 0, "f" : true }

So this uses my user settings

> db.rocketchat_subscription.find({"name":"offtopic"})
{ "_id" : "rx8jk6CcGDHwYqhXE", "open" : true, "alert" : false, "unread" : 0, "ts" : ISODate("2016-12-22T10:49:18.624Z"), "rid" : "kgYFD5tdpepALBdby", "name" : "offtopic", "t" : "c", "u" : { "_id" : "AuFSZhiWTKBnduXPb", "username" : "sndstrm" }, "_updatedAt" : ISODate("2018-04-03T19:25:46.520Z"), "ls" : ISODate("2018-04-03T19:25:46.520Z"), "mobilePushNotifications" : "all", "desktopNotifications" : "all", "desktopNotificationDuration" : 0, "userMentions" : 0, "groupMentions" : 0, "f" : true }

And this should override my settings and force push notifications, but neither web client nor RC+ on iOS does receive that.

Last option would be to rename the channel, recreate a new #general/#offtopic and change all values to the new one. But this would break # links.

@sampaiodiego
Copy link
Member

sampaiodiego commented Apr 3, 2018

@soundstorm just to confirm, do you receive a push notification if you're mentioned at those channels at the same conditions?

I've also found this (it's on Admin > General). does it apply to your case?
image

@soundstorm
Copy link
Contributor Author

soundstorm commented Apr 3, 2018

@sampaiodiego yeah, that's right.
The number of users exceeds 100, just set it to 0 to check, then used the wrong account to publish a message (and therefor got no notification regardless of the settings) but this fixed it.

The description is then misleading, as the "notify on all messages" will not override this limit. Description seems to be more like "override general user settings but use channel specific overrides". So maybe I leave that open to fix the description or the behaviour.

@soundstorm soundstorm changed the title [BUG] Only notifications on mentions even if set to "all messages" Max Room Members limit does not get overridden by user notifications="all messages" Apr 3, 2018
@sampaiodiego
Copy link
Member

yay 🎉 at least we found it! damn..

yep, I found the description misleading as well.. need to dig deeper to see if either the description or the implementation is wrong 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants