-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image embeds have the wrong hit target #1138
Comments
I think that's mostly because we display the image as the background-image of an empty |
@gmsecrieru — The approach you've mentioned (background image on a full-width div) also prevents #1139 from happening, at least from my brief testing. Is there a reason the img tag isn't used as-is? |
Not sure. @RocketChat/owners ? |
@gmsecrieru @liamdawson check out: #544 I think it might be a good chance to start a discussion about this. |
I think I can improve this using the same way that Slack does. |
@rodrigok i'm not familiar with how slack handles this. How do they do it? |
Created a pr that solves this: #1167 |
@geekgonecrazy @stefanlegg please see here #1170 |
You can click on the blank area at the right of the image and it still opens the image :(
The text was updated successfully, but these errors were encountered: