Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image embeds have the wrong hit target #1138

Closed
vjeux opened this issue Oct 16, 2015 · 8 comments
Closed

Image embeds have the wrong hit target #1138

vjeux opened this issue Oct 16, 2015 · 8 comments

Comments

@vjeux
Copy link

vjeux commented Oct 16, 2015

You can click on the blank area at the right of the image and it still opens the image :(

screen shot 2015-10-16 at 3 10 16 pm

@gmsecrieru
Copy link
Contributor

I think that's mostly because we display the image as the background-image of an empty div within an a tag, which takes up all the available width. I think we would need to define the maximum width of the image container somehow (related to original image) or take another approach.

@liamdawson
Copy link
Contributor

@gmsecrieru — The approach you've mentioned (background image on a full-width div) also prevents #1139 from happening, at least from my brief testing. Is there a reason the img tag isn't used as-is?

@gmsecrieru
Copy link
Contributor

Not sure. @RocketChat/owners ?

@geekgonecrazy
Copy link
Contributor

@gmsecrieru @liamdawson check out: #544

I think it might be a good chance to start a discussion about this.

@rodrigok
Copy link
Member

I think I can improve this using the same way that Slack does.

@geekgonecrazy
Copy link
Contributor

@rodrigok i'm not familiar with how slack handles this. How do they do it?

@stefanlegg
Copy link

Created a pr that solves this: #1167

@rodrigok
Copy link
Member

@geekgonecrazy @stefanlegg please see here #1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants