Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Opening a hidden channel/dm throws exception and does not show on sidebar #10723

Open
mikaelmello opened this issue May 9, 2018 · 1 comment

Comments

@mikaelmello
Copy link
Contributor

mikaelmello commented May 9, 2018

Description:

When you open a room that is hidden, two exceptions are thrown: Exception in queued task: Error: Can't set timers inside simulations and Exception in queued task: Error: Unknown id for changed: <roomId>

Server Setup Information:

  • Version of Rocket.Chat Server: 0.64.0 (reproducible on open.rocket.chat)
  • Operating System: Elementary OS
  • Deployment Method(snap/docker/tar/etc): Development
  • Number of Running Instances: 1
  • Node Version: v8.11.1

Steps to Reproduce:

  1. Open the browser's dev console
  2. Hide any channel or DM
  3. Go to the sideNav search and try to open the hidden channel or DM.

Expected behavior:

  1. A clean console
  2. Room open (check)
  3. Opened room being listed in the sideNav

Actual behavior:

  1. Two exceptions thrown are logged into the console
  2. Room open (check)
  3. Opened room not listed in the sideNav

Note: This behavior isn't consistent, sometimes it works, sometimes it does not.

Bonus bug:

If there are no current opens in a room section (example, no channels opened and "You are not part of any channel" displaying), when you open a hidden channel, the message is gone because there is a room now but it crashes before displaying.

@mikaelmello
Copy link
Contributor Author

The exception is thrown during the simulation of the openRoom method on client/methods/openRoom.js, called on packages/rocketchat-lib/client/lib/openRoom.js:79. A quick hack is to comment out the simulation method and everything will work as intended, but there is probably a good fix for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants